Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove custom sounds meteor.startup #30659

Merged
merged 9 commits into from
Oct 27, 2023
Merged

chore: Remove custom sounds meteor.startup #30659

merged 9 commits into from
Oct 27, 2023

Conversation

gabriellsh
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner October 17, 2023 17:01
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 60f79cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #30659 (60f79cd) into develop (e36c9ff) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #30659   +/-   ##
========================================
  Coverage    51.27%   51.27%           
========================================
  Files          813      812    -1     
  Lines        15129    15117   -12     
  Branches      2760     2759    -1     
========================================
- Hits          7757     7751    -6     
+ Misses        6961     6955    -6     
  Partials       411      411
Flag Coverage Δ
unit 64.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

tassoevan
tassoevan previously approved these changes Oct 18, 2023
View reviewed changes
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 26, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 26, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 27, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 27, 2023
@ggazzo ggazzo merged commit a5f79eb into develop Oct 27, 2023
15 of 16 checks passed
@ggazzo ggazzo deleted the chore/soundsStartup branch October 27, 2023 14:33
lmauromb pushed a commit that referenced this pull request Oct 30, 2023
@gabriellsh @lmauromb
chore: Remove custom sounds meteor.startup (#30659)
6502797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@tassoevan tassoevan tassoevan left review comments

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabriellsh @tassoevan @ggazzo